Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Site Package tutorial #143

Merged
merged 22 commits into from
Oct 27, 2023
Merged

Overhaul Site Package tutorial #143

merged 22 commits into from
Oct 27, 2023

Conversation

sarahmccarthy123
Copy link
Contributor

@sarahmccarthy123 sarahmccarthy123 commented Oct 9, 2023

Releases: main, 12.4

Releases:main, Backport 12.4)
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to link "composer.json" in the first paragraph to the page https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ExtensionArchitecture/FileStructure/ComposerJson.html.

-> Just reviewed the ExtensionConfiguration/Index page. Will have a look later at the others.

Documentation/ExtensionConfiguration/Index.rst Outdated Show resolved Hide resolved
Documentation/ExtensionConfiguration/Index.rst Outdated Show resolved Hide resolved
Documentation/ExtensionConfiguration/Index.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am still not finished yet. The PR is too big to review it in a short time. Maybe revise only one page per PR in the future.

Documentation/ExtensionInstallation/Index.rst Show resolved Hide resolved
Documentation/ExtensionInstallation/Index.rst Show resolved Hide resolved
Documentation/ExtensionInstallation/Index.rst Outdated Show resolved Hide resolved
Documentation/ExtensionInstallation/Index.rst Outdated Show resolved Hide resolved
Documentation/ExtensionInstallation/Index.rst Outdated Show resolved Hide resolved
Documentation/Introduction/Index.rst Outdated Show resolved Hide resolved
Documentation/Introduction/Index.rst Show resolved Hide resolved
Documentation/Introduction/Index.rst Show resolved Hide resolved
Documentation/Introduction/Index.rst Show resolved Hide resolved
Documentation/Introduction/Index.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forget about it. Now I am finished with that round of review ;-)

Documentation/Introduction/Index.rst Outdated Show resolved Hide resolved
Documentation/MinimalExample/Index.rst Outdated Show resolved Hide resolved
Documentation/MinimalExample/Index.rst Outdated Show resolved Hide resolved
Documentation/MinimalExample/Index.rst Show resolved Hide resolved
Documentation/MinimalExample/Index.rst Outdated Show resolved Hide resolved
Documentation/MinimalExample/Index.rst Outdated Show resolved Hide resolved
sarahmccarthy123 and others added 14 commits October 27, 2023 11:05
Co-authored-by: Chris Müller <[email protected]>
@brotkrueml brotkrueml merged commit 12d096f into main Oct 27, 2023
@brotkrueml brotkrueml deleted the sarah-overhaul-sitepackage branch October 27, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants