Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starr): Add DiRFiX in repack/proper CF #2153

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SeiyaGame
Copy link
Contributor

@SeiyaGame SeiyaGame commented Dec 4, 2024

Pull Request

Purpose

French trackers use DIRFIX a lot and mean :

  • Term used when a typo or inaccuracy is detected in the original version name

I don't know if it belongs in this CF because technically the release (the source file) hasn't changed, just a fix has been made to the realease name

Requirements

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Dec 4, 2024
@SeiyaGame SeiyaGame changed the title feat(starr) Add DiRFiX in repack/proper CF feat(starr): Add DiRFiX in repack/proper CF Dec 4, 2024
@bakerboy448
Copy link
Contributor

This will cause download loops as DIRFIX is not a recognized term for proper in Starr

@bakerboy448 bakerboy448 added the Do Not Merge Do Not Merge label Dec 4, 2024
@bakerboy448 bakerboy448 requested review from a team December 4, 2024 21:06
@rg9400
Copy link
Contributor

rg9400 commented Dec 4, 2024

This will cause download loops as DIRFIX is not a recognized term for proper in Starr

Right, it needs to be in a separate CF with rename enabled. Alternatively, we can enable rename in this CF itself since we are currently losing track of Repack vs Proper, but this will cause a lot of renames for people. The easier lift is just a separate CF

@SeiyaGame
Copy link
Contributor Author

Right, it needs to be in a separate CF with rename enabled. Alternatively, we can enable rename in this CF itself since we are currently losing track of Repack vs Proper, but this will cause a lot of renames for people. The easier lift is just a separate CF

I understand and it makes sense, we'll avoid impacting everyone. I'll make a separate CF and score it same as the CF repack/proper

@SeiyaGame
Copy link
Contributor Author

what score would be ideal for this CF?
I scored same as the CF repack/proper but I don't know if it's right.
Maybe put it at 4? just below repack/proper CF ?

@SeiyaGame SeiyaGame closed this Dec 6, 2024
@SeiyaGame SeiyaGame deleted the feat-add-dirfix-repack-cf branch December 6, 2024 18:41
@SeiyaGame SeiyaGame restored the feat-add-dirfix-repack-cf branch December 6, 2024 18:42
@SeiyaGame
Copy link
Contributor Author

SeiyaGame commented Dec 6, 2024

Sorry I renamed the branch on my repo but I didn't know it would close the issue

@SeiyaGame SeiyaGame reopened this Dec 6, 2024
@bakerboy448 bakerboy448 marked this pull request as draft December 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Do Not Merge Do Not Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants