Changes in file #1278
Changes in file #1278
Conversation
|
Thanks you for your pull request, Julieta. Do I understand correctly that you are proposing to add support for weighted masks? Can you please explain how you would want to use them? And also, how they should be taken into account by the image registration? I'm sorry we cannot merge your pull request in its current form. For one thing, the feature should still be tested. (Some sort of test should be added to our test framework.) But it should also have additional documentation. Then the git commits themselves should be more organized, maybe squashed together, with more detailed commit messages. Next week we will discuss if there is enough interest to implement this feature. |
|
I am so sorry about this issue.
I am still developing the feature. I made a mistake with the pull request
to the main repository.
Thanks for reaching out.
…On Fri, Dec 13, 2024, 7:50 AM Niels Dekker ***@***.***> wrote:
Thanks you for your pull request, Julieta. Do I understand correctly that
you are proposing to add support for weighted masks? Can you please explain
how you would want to use them? And also, how they should be taken into
account by the image registration?
I'm sorry we cannot merge your pull request in its current form. For one
thing, the feature should still be tested. (Some sort of test should be
added to our test framework.) But it should also have additional
documentation. Then the git commits themselves should be more organized,
maybe squashed together, with more detailed commit messages.
Next week we will discuss if there is enough interest to implement this
feature.
—
Reply to this email directly, view it on GitHub
<#1278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC3ASW2OBABCTUR2L3HSKUT2FLJY7AVCNFSM6AAAAABTQ5IIBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBRGM4TMNZTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Just marked your pull request "Request changes" to avoid merging accidentally. So it is not really a "change request" to you. It is really up to you if you would like to proceed with this pull request. You may also just close the pull request, if that is what you want!
|
Thank you,
And again sorry for the confusion
…On Fri, Dec 13, 2024, 9:08 AM Niels Dekker ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Just marked your pull request "Request changes" to avoid merging
accidentally. So it is not really a "change request" to you. It is really
up to you if you would like to proceed with this pull request. You may also
just close the pull request, if that is what you want!
—
Reply to this email directly, view it on GitHub
<#1278 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC3ASW4S2GM4BTZ7VW2EACD2FLS5NAVCNFSM6AAAAABTQ5IIBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBSGM4DENBWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No description provided.