Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update action to use node 20 #9

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[Feature] Update action to use node 20 #9

merged 2 commits into from
Oct 24, 2023

Conversation

danielmarcano
Copy link
Contributor

@danielmarcano danielmarcano commented Oct 18, 2023

Related to Issue #9895

The following changes have been made because GitHub Actions will no longer support Node.js v12, as mentioned by @williamjallen in the linked issue. You can find the relevant information in the blog post referenced in that issue.

  1. Updated action.yml so that it uses Node.js version 'node20'
  2. Updated README.md to reflect this change
  3. Updated test.yml matrix node-version array to [20.x]
  4. Updated version to 2.0.0 in package.json to reflect this change, as this is a breaking change, according to the rules of semantic versioning
  5. Upgraded @types/node version to "^20.8.7" to match Node.js v20 version

I have conducted a search for other repositories using Node.js v12 and identified the following three repositories, so I have opened other PRs updating Node.js to v20 in them:

Checks:

[x] Have run npm run lint and npm run test as specified in the README.md

P.S. If this PR is accepted, could you please add the "hacktoberfest-accepted" label to it, so that it counts towards my Hacktoberfest contributions?

Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the @types/node devDependency that should be upgraded to the same major version so that developers can use whatever new syntax features are allowed in that version.

action.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@danielmarcano danielmarcano changed the title [Feature] Update the action's node.js version to v16, as GitHub Actions will no longer support v12 [Feature] Update the action's node.js version to v20, as GitHub Actions will no longer support v12 Oct 18, 2023
@danielmarcano
Copy link
Contributor Author

Hi, @MasterOdin! I have just updated the PR, including all the changes you have mentioned.

If you consider that it's good to go, could you please add the "hacktoberfest-accepted" label to it?

Thanks for everything ✨

@MasterOdin MasterOdin added the hacktoberfest-accepted PR that has been accepted during Hacktoberfest label Oct 24, 2023
@MasterOdin MasterOdin changed the title [Feature] Update the action's node.js version to v20, as GitHub Actions will no longer support v12 [Feature] Update action to use node 20 Oct 24, 2023
@MasterOdin MasterOdin merged commit d740eb9 into Submitty:main Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR that has been accepted during Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants