-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor:System] change the content of the "title check" to be more descriptive #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses the issue accordingly, as well as the test.
Looks good to me, but someone with more control should take a look at the format.
@williamjallen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem reasonable to me. Thanks for this contribution @kacperswis!
The pleasure is all mine |
test/validate.spec.ts
Outdated
"Dependency", | ||
"DevDependency", | ||
]; | ||
const allowedModules = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of repeating these two arrays across here and src/validate.ts
, I would just export the arrays in src/validate.ts
to reuse them here, so that it lowers the barrier of adding new values.
Hmm, the title check github action should be enabled on this repository as well. |
@kacperswis Please make the change requested by @MasterOdin |
sure, today I will try to do this ;) |
Thanks @kacperswis for your contribution! |
change the content of the "title check" to be more helpful and descriptive
Fixes #9894