Functionality to generate Standard PR titles #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are you trying to accomplish? Using the function you have proposed is almost certainly more work than just typing out the characters of the prefix. |
|
Please create an issue or join our Zulip chat to discuss this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality:
We can then use this function to generate PR titles in a standardized manner before submitting a PR.
Solution:
Added a function that takes the type, module, and subject as input and generates a formatted PR title in validate.ts. This function should also perform length checks and exclude the issue # if present. Have added the method to test the function in spec.ts
Risk level:
How to test:
Add a console in the method in spec to print formattedTitle
ng run test
Screenshots