RD-1601 py2 py3 setup #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IliaFeldgun
force-pushed
the
PEP-440
branch
5 times, most recently
from
8fa46af to
825829a
Compare
IliaFeldgun
requested review from
ofir-amir,
khizunov,
roeigo-stratoscale,
tomerschwartz24,
grishatsuker,
simba1997,
ave6192 and
shaitourchin
IliaFeldgun
force-pushed
the
PEP-440
branch
2 times, most recently
from
b95669a to
50d1d39
Compare
grishatsuker
approved these changes
Jun 18, 2024
| import sys | ||
| import time | ||
| import signal | ||
| import strato.common.log.morelevels # relies on side effects |
There was a problem hiding this comment.
https://peps.python.org/pep-0008/#imports
usually the import order is
- standard libraries
- 3rd part libraries
- package related libraries
fix encoding issues semver support skipperize remove upseto
Harelfel
approved these changes
Jul 23, 2024
roeigo-stratoscale
approved these changes
Aug 12, 2024
| @@ -0,0 +1,4 @@ | |||
| python-setuptools-plugins==0.0.2+g865898c | |||
| pyyaml | |||
| f = sys._getframe(3) | ||
| def _findCallerPyAgnostic(*args, **kwargs): | ||
| FILE_BLACKLIST = ['logging/__init__.py', 'common/log/morelevels.py', 'configurelogging.py'] | ||
| f = logging.currentframe() |
| return (filename, f.f_lineno, co.co_name) | ||
| return ("(unknown file)", 0, "(unknown function)") | ||
| if sys.version_info[0] == 2: | ||
| return (filename, f.f_lineno, co.co_name) |
There was a problem hiding this comment.
what is co? I know some were already this way, but I really can't understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pep-440 versioning
upseto remove (but support paths)
fixed encoding
http://strato-pypi.dc1.strato:5002/strato/staging/strato-common-log/0.0.1.dev0+g825829a
http://jenkins.dc1.strato:8080/job/Clean-Build-NextGen/381/console
http://jenkins.dc1.strato:8080/job/monkey-ci/view/change-requests/job/PR-6100/18/console
TODO:
buildpython-setuptools-pluginswheel