Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flag to Enable IPC #234

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

sachinkum0009
Copy link
Contributor

@sachinkum0009 sachinkum0009 commented Aug 30, 2024

- To support the workspace that required IPC for communcation bw different workspace
@sachinkum0009 sachinkum0009 requested a review from muritane August 30, 2024 14:47
docs/rtwcli/index.rst Outdated Show resolved Hide resolved
docs/rtwcli/index.rst Outdated Show resolved Hide resolved
docs/rtwcli/index.rst Outdated Show resolved Hide resolved
Copy link

mergify bot commented Sep 3, 2024

This pull request is in conflict. Could you fix it @sachinkum0009?

@mamueluth
Copy link
Member

@muritane should this be removed from the import verb as well?

@muritane
Copy link
Contributor

muritane commented Sep 5, 2024

@muritane should this be removed from the import verb as well?

No, the IPC flag is parsed to generate_rocker_flags and it should thus stay there: https://github.com/StoglRobotics/ros_team_workspace/pull/234/files#diff-370cb1f8496b8a223ff6e3e8c41ed4c47e2beb059c937cfe034950894cf5d901R146

@muritane muritane merged commit 7167a7a into StoglRobotics:master Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants