Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Controller Tools to v2.0.0 #710

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

eXhumer
Copy link
Contributor

@eXhumer eXhumer commented Oct 13, 2024

Controller Tools

Re-opening #708 with a different branch. I opened a PR on main branch for CheatDeck update, which closed the original Controller Tools PR. I copy pasted the PR form as is and am adding this text. Modify as necessary.

  • Refactor plugin to use new decky API
  • Bump backend dependencies

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@TrainDoctor
Copy link
Member

@ds22x provided this review for the original PR:

Decky v3.0.1, SteamOS Stable 3.5.19:
A) None.
B) None.
C) AutoFlatpaks 1.6.7; steamdeck-input-disabler 1.0.2; SteamGridDB 1.5.1-loaderv2; TabMaster 2.7.0; Wine Cellar 0.1.5
D) Yay

@dm82m
Copy link

dm82m commented Oct 16, 2024

Works for me on current SteamOS Beta + Decky Pre-Release version. Thanks for taking care @eXhumer !

@TrainDoctor
Copy link
Member

Works for me on current SteamOS Beta + Decky Pre-Release version. Thanks for taking care @eXhumer !

@dm82m, thanks for the review. In future if you'd like your review to be suitable for review when sending a plugin to the production store, make sure to review this section when submitting your testing report https://deckbrew.xyz/testing#submitting-a-test-report

@TrainDoctor TrainDoctor requested a review from a team October 22, 2024 18:33
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since multiple testers have come forward and reported the plugin working I feel this is sufficient for the plugin to go into the production store.

@TrainDoctor TrainDoctor merged commit 90c4a9b into SteamDeckHomebrew:main Oct 22, 2024
2 checks passed
@eXhumer eXhumer deleted the controller-tools-v2.0.0 branch October 22, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants