feat: Add announcements system #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const welcomeAnnouncement: Announcement = { | ||
| id: 'welcomeAnnouncement', | ||
| title: 'Welcome to Decky!', | ||
| text: 'We hope you enjoy using Decky! If you have any questions or feedback, please let us know.', |
There was a problem hiding this comment.
Where should people direct feedback?
(Also i assume this shows the first time you use decky? Might want to add something like start with looking at the store)
There was a problem hiding this comment.
That's a good point, but there is another blocking issue. The text need to be moved in en-US.json and not hardcoded here.
TrainDoctor
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Remaining items before merge:
- Announcements must be checked for regularly similar to checks for updates to decky and for plugins.
- Markdown support for URLs etc.
- Announcements should not be active by default decky-plugin-store#73
- Store needs to expose modifiable expiration timeframe that is applied to all announcements by default.
- Announcements panel exposes active/inactive status Plugin-Store-Admin#1
- Also needs to provide edit field for default announcement expiration timeframe.
- Announcement telling you which store you're on (optional but helpful)
- Should be able to be disabled for frequent testers etc.
@beebls, @gbdlin and @AAGaming00: please make sure to coordinate with me so we can get this out asap.
- Should be able to be disabled for frequent testers etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/
Description
This fixes issue: #672
Adds an Announcements (formerly MOTD) display to the root QAM view,
The [plugins/testing].deckbrew.xyz/v1/-/announcements/current endpoint is used, and the latest announcement from this endpoint is display in the QAM.
Upon clicking the X button, that announcement's id is added to a hidden announcements list so that it isn't displayed again