-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google API, Base64 implementation + other goodies #2455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mau11
reviewed
Sep 16, 2024
@@ -127,7 +127,7 @@ | |||
"express": "^4.19.2", | |||
"fs": "^0.0.2", | |||
"google-libphonenumber": "^3.2.35", | |||
"googleapis": "^39.2.0", | |||
"googleapis": "^144.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 lol
mau11
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
The previous implementation of the Google Import feature had the application use a rather large and uncomfortable JSON object that would be placed in the env as a string. This method often fractured, or introduced unexpected tokens in the object. This PR replaces GOOGLE_SECRET with BASE64_GOOGLE_SECRET.
Description
The Google Secrete JSON object will now be encoded in base64, representing important information such as the API private key and client email. Instructions have been added to the documentation for how to convert the JSON object directly to base64, a method I had to use to ensure that the JSON object is represented 1 to 1 when eventually parsed in the application.
Encoding private keys in base64 is also industry standard.
Other Goodies
Upgraded
googleapis
Removed
abortController
for native supportUpgrade gitHub actions
upload-artifact
to V4 (V2 was deprecated June 30th, 2024)Add
spoke-pm2.config.js
to.gitignore
Checklist: