Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error when saving or deleting canned responses with tags #2452

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

mau11
Copy link
Member

@mau11 mau11 commented Sep 13, 2024

Fixes # (issue)

Description

Bug reported that canned responses are not saving:
Screenshot 2024-09-11 at 8 49 20 PM
This type error prevented users from creating, editing, uploading and deleting canned responses that contained tags.

Also updated the UI to show entire canned response text (text was cut off when a canned response also had an action handler):

before

Screenshot 2024-09-13 at 2 57 23 AM

after

Screenshot 2024-09-13 at 2 54 51 AM

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@mau11 mau11 force-pushed the mz/canned-resp-type-error branch from 50aa249 to 42f99ac Compare September 13, 2024 07:12
Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mau11 mau11 merged commit f0ee27e into stage-main-14.1 Sep 19, 2024
17 checks passed
@mau11 mau11 mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 14.1
Development

Successfully merging this pull request may close these issues.

2 participants