[Enhancement] adjust agg pushdown strategy for broadcast #54572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-shelby
force-pushed
the
update_aggpushdown_para
branch
from
a33f129 to
0d5523b
Compare
stephen-shelby
changed the title
Signed-off-by: stephen <[email protected]>
stephen-shelby
force-pushed
the
update_aggpushdown_para
branch
from
0d5523b to
3220466
Compare
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Jan 3, 2025
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 10 / 12 (83.33%) file detail
|
murphyatwork
approved these changes
Jan 3, 2025
|
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Signed-off-by: stephen <[email protected]> (cherry picked from commit 04ddf66)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 3, 2025
…4572) (#54652) Co-authored-by: stephen <[email protected]>
|
@Mergifyio backport branch-3.4.0-rc01 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Signed-off-by: stephen <[email protected]> (cherry picked from commit 04ddf66)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 3, 2025
…4572) (#54655) Co-authored-by: stephen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
the current agg pushdown only considers the degree of aggregation. but in the case of broadcast join and smaller right table, agg takes longer than join costs without pushing. so we need to adjust agg pushdown strategy.
What I'm doing:
Prioritize join cost before considering aggregation degree
we don't pushdown agg under following conditions:
cbo_push_down_aggregate_on_broadcast_join_row_count_limit. default value is 25wssb_100 16 concurrency
tpcds 1t 1 concurrency
no performace downgrade before and after adjustment at tpcds_100g/tpch_100g/ssbflat_100g dataset.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: