[Enhancement] improve performance of show materialized views statement #54374
+143
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/scheduler/history/TaskRunHistory.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/scheduler/history/TaskRunHistoryTable.java
Show resolved
Hide resolved
Signed-off-by: Murphy <[email protected]>
murphyatwork
force-pushed
the
murphy_opt_mv_list_task_runs
branch
from
ff484b6 to
b309d0c
Compare
murphyatwork
changed the title
satanson
previously approved these changes
Dec 26, 2024
LiShuMing
reviewed
Dec 26, 2024
| " JOIN MaxStartRunID msr" + | ||
| " ON t.task_name = msr.task_name" + | ||
| " AND cast(t.history_content_json->'startTaskRunId' as string) = msr.start_run_id" + | ||
| " ORDER BY t.create_time DESC"; |
There was a problem hiding this comment.
after this, the max size that history table will output will be task's number, am I right?
LiShuMing
previously approved these changes
Dec 26, 2024
| " JOIN MaxStartRunID msr" + | ||
| " ON t.task_name = msr.task_name" + | ||
| " AND cast(t.history_content_json->'startTaskRunId' as string) = msr.start_run_id" + | ||
| " ORDER BY t.create_time DESC"; |
murphyatwork
dismissed stale reviews from LiShuMing and satanson
via
fe7cd4e
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 8 / 26 (30.77%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
When executing
SHOW MATERIALIZED VIEWS, it is necessary to check the status of the last job.Currently, we retrieve all historical records for a materialized view (MV), which can be slow when there are many entries. To improve performance, we now only query the records for the most recent job.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: