Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] One-staged spillable aggregation's having predicates should not applied to pre-cache aggregate operator #54257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IHEII
Copy link
Contributor

@IHEII IHEII commented Dec 24, 2024

Why I'm doing:

Fix the same issue in the SpillableAggregationBlockingSourceOperator that corresponds to #43803

What I'm doing:

Fix the same issue in the SpillableAggregationBlockingSourceOperator

If current AggregateBlockSourceOperator is a pre-cache operator, the output format of aggregation columns
is binary column(for an example: multi_count_distinct) generated by AggregationFunction::serialize_column, having predicates applying to this intermediate format cause BE's crash.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

…not applied to pre-cache aggregate operator

Signed-off-by: IHEII <[email protected]>
@IHEII IHEII requested a review from a team as a code owner December 24, 2024 04:01
@mergify mergify bot assigned IHEII Dec 24, 2024
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant