Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 6 language mode #20

Merged
merged 7 commits into from
Dec 21, 2024
Merged

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Dec 21, 2024

Support Swift 6 language mode

♻️ Current situation & Problem

SpeziChat currently does not support Swift 6 language mode with complete concurrency checking.

Addresses #15

⚙️ Release Notes

  • Support Swift 6 language mode
  • Lift dependencies
  • Fix UI tests on iOS and macOS

📚 Documentation

Necessary workarounds regarding the MainActor documented

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Dec 21, 2024
@philippzagar philippzagar self-assigned this Dec 21, 2024
Package.swift Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (2fa1a93) to head (1bcf50f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/SpeziChat/ChatView.swift 69.24% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   80.69%   80.47%   -0.21%     
==========================================
  Files          15       15              
  Lines         756      768      +12     
==========================================
+ Hits          610      618       +8     
- Misses        146      150       +4     
Files with missing lines Coverage Δ
Sources/SpeziChat/ChatView+ShareSheet.swift 69.24% <ø> (ø)
.../SpeziChat/Helpers/MessageInputViewHeightKey.swift 50.00% <ø> (ø)
...peziChat/Models/ChatEntity+HiddenMessageType.swift 100.00% <ø> (ø)
Sources/SpeziChat/ChatView.swift 65.22% <69.24%> (+0.22%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa1a93...1bcf50f. Read the comment docs.

Copy link
Contributor

@LeonNissen LeonNissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

Sources/SpeziChat/ChatView.swift Show resolved Hide resolved
Sources/SpeziChat/ChatView.swift Show resolved Hide resolved
@philippzagar philippzagar merged commit 21e235a into main Dec 21, 2024
18 checks passed
@philippzagar philippzagar deleted the feat/swift-6-language-mode branch December 21, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants