Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-to-speech capabilities #11

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Text-to-speech capabilities #11

merged 9 commits into from
Feb 22, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Feb 21, 2024

Text-to-speech capabilities

♻️ Current situation & Problem

Currently, SpeziChat provides speech-to-text capabilities but no integration with the text-to-speech capabilities of SpeziSpeech.

⚙️ Release Notes

  • Add text-to-speech capabilities to the ChatView via the .speak() and .speechToolbarButton() view modifiers

📚 Documentation

Added inline Docs

✅ Testing

Adjusted UI tests

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar self-assigned this Feb 21, 2024
@philippzagar philippzagar added the enhancement New feature or request label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8233230) 83.50% compared to head (5317ecc) 84.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   83.50%   84.14%   +0.64%     
==========================================
  Files          11       13       +2     
  Lines         503      580      +77     
==========================================
+ Hits          420      488      +68     
- Misses         83       92       +9     
Files Coverage Δ
Sources/SpeziChat/ChatView+SpeechButton.swift 100.00% <100.00%> (ø)
Sources/SpeziChat/Helpers/TypingIndicator.swift 100.00% <100.00%> (ø)
Sources/SpeziChat/MessageInputView.swift 83.19% <100.00%> (+0.46%) ⬆️
Sources/SpeziChat/MessageView.swift 100.00% <ø> (ø)
Sources/SpeziChat/MessagesView.swift 88.89% <100.00%> (+0.49%) ⬆️
Sources/SpeziChat/Models/ChatEntity.swift 88.89% <100.00%> (+0.89%) ⬆️
Sources/SpeziChat/ChatView.swift 83.88% <85.72%> (+0.27%) ⬆️
Sources/SpeziChat/ChatView+SpeechOutput.swift 77.50% <77.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8233230...5317ecc. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippzagar Thank you for the changes; looks great and we only need to incorporate the feedback we discussed in our meeting 🚀

Sources/SpeziChat/ChatView+SpeechButton.swift Outdated Show resolved Hide resolved
Sources/SpeziChat/ChatView+SpeechOutput.swift Outdated Show resolved Hide resolved
@philippzagar philippzagar enabled auto-merge (squash) February 22, 2024 05:58
@philippzagar philippzagar merged commit ad4c88a into main Feb 22, 2024
9 checks passed
@philippzagar philippzagar deleted the feat/speech-capabilities branch February 22, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants