Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on: workflow_dispatch #74 #75

Conversation

jpavlav
Copy link
Contributor

@jpavlav jpavlav commented Mar 25, 2024

This should allow folks with the appropriate permissions to re-run/run test action executions.

#74

This should allow folks with the appropriate permissions to re-run/run
test action executions.
@jpavlav jpavlav requested review from floatingstatic and a team as code owners March 25, 2024 20:11
@jpavlav jpavlav requested review from amanda11 and removed request for a team March 25, 2024 20:11
@jpavlav jpavlav changed the title Add on: workflow_dispatch #72 Add on: workflow_dispatch #74 Mar 25, 2024
@jpavlav
Copy link
Contributor Author

jpavlav commented Mar 25, 2024

@floatingstatic Hey there! Just wanted to push this up so folks wouldn't have to force push to get tests run again. This should allow someone with the appropriate permissions to run these test workflows via a button in the GUI. The tests are failing here, because there is an expectation that the pack and CHANGE.md will always be updated. I think it might be a good idea to have this GHA workflow ignore the .github/** path.

@floatingstatic
Copy link
Collaborator

@jpavlav is this still needed now that we have #73 merged? I was able to re-run tests in checks/actions after TSC worked some magic.
If you think we still need this can you rebase your branch on the latest changes in master (so we drop py3.6 tests, etc.), otherwise we can close this. Thanks!

@jpavlav
Copy link
Contributor Author

jpavlav commented Mar 28, 2024

Oh okay! If you have the ability to trigger the jobs to run again then 👍 that's all this was for. We can close the related issue #74.

@jpavlav jpavlav closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants