-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDNA proposal #2874
base: main
Are you sure you want to change the base?
IDNA proposal #2874
Conversation
Mentioning a number of people that I suspect have IDNA domains or knowledge about how IDNA works (based on skimmy bugs and PRs) @adamus1red I'd love to receive feedback about this proposal! |
I think your example for the asci==unicode exampe might be wrong:
Was this what you intended? |
I noticed you created both CREATE and MODIFY examples for |
Ah, good point! The first one is where the label is ascii==unicode but the target is ascii!=unicode. I'll update the comment. Thanks for finding that! Tom |
I've added more examples. I don't think I've covered every combination, but my goal is to show typical examples not every possible example. I've also added examples where we use {} and |
While I'm not against having the ASCII and UTF on the output lines, I do worry it might make the output too busy. |
LGTM |
@adamus1red wrote:
That's an interesting point! I guess my thought is that showing both versions helps with debugging. |
@tlimoncelli maybe a compromise would be if the output was the same as what the DNS provider or Registrar used. I know I've had issues where the DNS is using UTF but the registrar is using ASCII. I.e. namecheap uses ascii, so for registrar stuff using namecheap use ascii punycode and the DNS is cloudflare which uses UTF, so the output uses UTF. |
The only IDNA domain I have is for fun, so I don't have a strong preference. I'll give my input nonetheless :). If you want to show both, I think I like B better, as it feels more consistent to me. Anything not in brackets will always be ASCII that way. I'd probably go with showing what the original user input was, with a flag to only show ASCII if needed. It's less information to parse, and the user should be familiar with it as that's the way it's listed in their config. I could see points being made for showing both, but I've always liked things more distraction free and less dense. I think the Unicode brackets are a little too clever, perhaps even a little confusing ;) |
First of all, improving IDNA handling would be a great improvement to dnscontrol. Regarding output, the one thing I definitely do not like is having the ascii output come first, because it is the one least likely to be understood/mentally associated with the relevant domain. I think simply using the original user input has merit, pairing that with a toggle to additionally show ascii seems fine to me. |
I'm seconding this suggestion, by displaying the "human readable" format I think the barrier for using IDN's with dnscontrol is getting lowered. Because the IDNA format is not human readable, especially when it comes to non-latinized languages. |
This is excellent feedback! It's getting me excited! Question: In what situations would people want to see something besides the .Name (the user input) version? |
What about if the registrar or dns provider use something different than the .Name value, then include the version they are using in brackets? |
Personally, I think whatever the dns provider does isn't relevant to the cli output. Behind the scenes at every provider, it's all punycode anyway. |
Agreed, having the display format handled outside of the provider is to be preferred IMO. |
I don't have experience with IDNA at all. |
Hi folks! 2 ideas: Support multiple formats?There's been a lot of discussion about I'll know more if this is possible when I start coding. An idea that would break less existing codeExisting code expects .Name to be ASCII (the current code runs dc.Punycode() for all providers, which rewrites .Name to be ASCII). Rather than require every use of .Name to change to .NameASCII, maybe the names should be: .Name (ASCII, to be compatible with old code), .NameORIG (how the user input the string), .NameUNICODE, and .NameDisplay. |
No description provided.