Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mod name to Sponge with capital S #3437

Closed
wants to merge 1 commit into from

Conversation

MrSlimeDiamond
Copy link

I know I'm being a little picky here but it annoys me a little lol.

I know I'm being a little picky here but it annoys me a little lol.
@dualspiral
Copy link
Contributor

I'm going to close this, for a couple of reasons:

  • We prefer that minor changes (including typos) are reported in Ongoing Minor Issue List (Sponge Edition) #23, that way we can group them all together.
  • This isn't really a change that I want to make. This is simply the "server branding" and generally isn't that visible - in Vanilla the brand is also lowercase.
  • "Because it annoys you a little" is not really a reason that we accept changes like this. When proposing a change, please be prepared to back up why such a change is necessary. For things like this, feel free to ask us why we've chosen to do it in this way on Discord because there may be deeper reasons to consider (probably not the case here but changing the case of a string that is used as an ID can easily break things).

Thanks!

@dualspiral dualspiral closed this Jun 20, 2021
@kashike kashike added the resolution: wontfix This will not be worked on label Jun 20, 2021
@MrSlimeDiamond MrSlimeDiamond deleted the patch-1 branch June 21, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants