-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codecov tests #3569
Fix codecov tests #3569
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
+ Coverage 71.57% 71.69% +0.12%
==========================================
Files 311 311
Lines 36179 36232 +53
==========================================
+ Hits 25894 25978 +84
+ Misses 10285 10254 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
@@ -47,7 +47,7 @@ jobs: | |||
echo "$file was changed" | |||
done | |||
|
|||
- name: Set testing environment # This decides which tests are run and whether to install especial dependencies | |||
- name: Set testing environment # This decides which tests are run and whether to install special dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My Spanish speaking self came out yelling on this one.
The failing tests seem to be IBL : / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks good to me :) It'll be nice to have the green box again !
Pinned one-api... |
Thansk for the hint @h-mayorquin
Tests passing: https://github.com/SpikeInterface/spikeinterface/actions/runs/12157608869