Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov tests #3569

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Fix codecov tests #3569

merged 5 commits into from
Dec 6, 2024

Conversation

alejoe91
Copy link
Member

@alejoe91 alejoe91 commented Dec 4, 2024

@alejoe91 alejoe91 requested a review from h-mayorquin December 4, 2024 13:33
@alejoe91 alejoe91 added the continuous integration Related to CI label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.69%. Comparing base (3fd3d97) to head (922606b).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3569      +/-   ##
==========================================
+ Coverage   71.57%   71.69%   +0.12%     
==========================================
  Files         311      311              
  Lines       36179    36232      +53     
==========================================
+ Hits        25894    25978      +84     
+ Misses      10285    10254      -31     
Flag Coverage Δ
unittests 71.69% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@@ -47,7 +47,7 @@ jobs:
echo "$file was changed"
done

- name: Set testing environment # This decides which tests are run and whether to install especial dependencies
- name: Set testing environment # This decides which tests are run and whether to install special dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Spanish speaking self came out yelling on this one.

@h-mayorquin
Copy link
Collaborator

The failing tests seem to be IBL : /

Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me :) It'll be nice to have the green box again !

@alejoe91
Copy link
Member Author

alejoe91 commented Dec 6, 2024

The failing tests seem to be IBL : /

Pinned one-api...

@alejoe91 alejoe91 merged commit 0963611 into main Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants