Matched filtering with both peak signs simultaneously #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ace into mf_with_both_peak_signs
for more information, see https://pre-commit.ci
|
This PR should not be merged as it is, because even if this is working without error, the behavior is strange. I suspect that, in the numba kernel, there is a corner case as mentioned by @samuelgarcia that wrote it with inequalities, such that if templates are at the same spot, we are keeping all peaks. Currently, if only neg or pos is selected for the peak type, this is working fine. But with both, we have way too many peaks detected.... |
|
@samuelgarcia I've found the bug and I've patched it. This is maybe too late for the release, but since it was tagged at some point. Now this branch is working as expected! |
… into mf_with_both_peak_signs
…mf_with_both_peak_signs
for more information, see https://pre-commit.ci
|
@samuelgarcia I've added the optimisation we discussed for convolution in this PR, and this is ready to go on my side |
samuelgarcia
approved these changes
Oct 7, 2024
|
Bien joué. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should allow matched filtering to work with both positive and negative peak sign detection. If both is selected, then templates are duplicated with a sign inversion, and added to the dictionary of templates.
I've also added a drastic speed up of the function, by simplification of the convolution