-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add USB and dev mode commands #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice commit, thanks for your contribution
If possible, please add our license description at the top of some important code, like here
https://github.com/SonicCloudOrg/sonic-ios-bridge/blob/main/cmd/afc.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve
I have a question, are you sure you can control the power switch of the USB port? What usbhub and operating system is it suitable for? |
I only tested on Linux. 😛 You can refer to this list for (possibily) compatible USB hubs (though my hubs aren't listed here, it still works): https://github.com/mvp/uhubctl#compatible-usb-hubs |
Looks like an error occurred when compiling, maybe you need to fix it a bit |
As far as I know, there may be issues with USB on Windows. The main concept of this tool is universality, so you can separate the USB function from PR and we will place it in another branch. If users need this function, they can go to that branch on their own |
@sam80180 You may need to resubmit the PR, @ZhouYixun he hastily merged, but there are many issues that need to be determined. I will reset the master branch |
how about adding build tags for non-Windows systems to those USB-related files ? |
Checklist
Description