Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add USB and dev mode commands #69

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

sam80180
Copy link

@sam80180 sam80180 commented Nov 17, 2023

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并,Sonic组织都非常感谢您的贡献。

Checklist

  • [v] The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • [v] I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • [v] I have considered and confirmed that this submission is valuable to others. | 我已经考虑过,并确认这份呈件对其他人很有价值。
  • [v] I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

@prlabeler prlabeler bot added the feature feature label Nov 17, 2023
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice commit, thanks for your contribution

If possible, please add our license description at the top of some important code, like here
https://github.com/SonicCloudOrg/sonic-ios-bridge/blob/main/cmd/afc.go

Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@ZhouYixun
Copy link
Member

I have a question, are you sure you can control the power switch of the USB port? What usbhub and operating system is it suitable for?

@sam80180
Copy link
Author

I only tested on Linux. 😛

You can refer to this list for (possibily) compatible USB hubs (though my hubs aren't listed here, it still works): https://github.com/mvp/uhubctl#compatible-usb-hubs

@ZhouYixun ZhouYixun merged commit 67169b6 into SonicCloudOrg:main Nov 20, 2023
1 check failed
@ZhouYixun
Copy link
Member

I only tested on Linux. 😛

You can refer to this list for (possibily) compatible USB hubs (though my hubs aren't listed here, it still works): https://github.com/mvp/uhubctl#compatible-usb-hubs

Looks like an error occurred when compiling, maybe you need to fix it a bit

@aoliaoaoaojiao
Copy link
Member

I only tested on Linux. 😛

You can refer to this list for (possibily) compatible USB hubs (though my hubs aren't listed here, it still works): https://github.com/mvp/uhubctl#compatible-usb-hubs

As far as I know, there may be issues with USB on Windows. The main concept of this tool is universality, so you can separate the USB function from PR and we will place it in another branch. If users need this function, they can go to that branch on their own

@aoliaoaoaojiao
Copy link
Member

aoliaoaoaojiao commented Nov 20, 2023

@sam80180 You may need to resubmit the PR, @ZhouYixun he hastily merged, but there are many issues that need to be determined. I will reset the master branch

@sam80180
Copy link
Author

how about adding build tags for non-Windows systems to those USB-related files ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants