WIP winit: Call create_window in resumed; not deprecated way
#1514
+158
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`EventLoop::create_window()` is removed in winit git, so it seems we'll need to change this eventually. This isn't that hard to update in Smithay, but in the compositor it's a bit awkward to not have a window / EGL context / renderer until an event is sent from the backend...
ids1024
added a commit
to ids1024/smithay
that referenced
this pull request
Aug 26, 2024
I wanted to see how the changes in Winit git would work here. So of course this depends on that being released. Depends on Smithay#1514. It doesn't seem to pose a particular challenge beyond that. Updating compositors for that change will be needed to test this...
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventLoop::create_window()is removed in winit git, so it seems we'll need to change this eventually.This isn't that hard to update in Smithay, but in the compositor it's a bit awkward to not have a window / EGL context / renderer until an event is sent from the backend...