Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mqtt client empty client name #2898

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

pljakobs
Copy link
Contributor

hopefully now conforming to the coding style rules

Copy link

what-the-diff bot commented Oct 28, 2024

PR Summary

  • Added Non-Empty Client Name Verification in Connect Method
    We've incorporated a new rule in the connect process that verifies the clientName is not left blank. If it's empty, an error log will be generated to alert us. This helps us maintain solid connection integrity and improve troubleshooting.

@pljakobs
Copy link
Contributor Author

I hope this now is ok. Having to run clang-8 on Fedora 40 is not ideal, I ended up creating a container to run it in.

@slaff slaff added this to the 6.0.0 milestone Oct 28, 2024
@slaff slaff merged commit 0447ab4 into SmingHub:develop Oct 28, 2024
32 checks passed
@mikee47
Copy link
Contributor

mikee47 commented Oct 28, 2024

I hope this now is ok. Having to run clang-8 on Fedora 40 is not ideal, I ended up creating a container to run it in.

I use a stand-alone build of clang-format-8 which you can find here https://github.com/muttleyxd/clang-tools-static-binaries/releases/tag/master-32d3ac78. Something like:

cd $SMING_HOME
wget https://github.com/muttleyxd/clang-tools-static-binaries/releases/download/master-32d3ac78/clang-format-8_linux-amd64
export CLANG_FORMAT=/opt/clang-format-8
mv clang-format-8_linux-amd64 $CLANG_FORMAT
chmod +x $CLANG_FORMAT
make cs

slaff pushed a commit that referenced this pull request Oct 31, 2024
This PR updates the Sming coding style documentation as discussed in #2898 (comment) and #2904 (comment).

Sming requires version 8 which is generally no longer available in the standard repositories for recent GNU/Linux distributions. Different versions of clang-format produce different output with the same configuration. This is such a common problem that a kind soul has provided standalone builds here https://github.com/muttleyxd/clang-tools-static-binaries/releases.

The default name of the clang-format executable has been changed to `clang-format-8`. This is because `clang-format` is now very unlikely to be the default installed version, and so avoids the subtle issues with running the wrong version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants