CraftingTweaks compatibility #5277
Conversation
|
|
||
| @Override | ||
| public boolean handles(AbstractContainerMenu menu) { | ||
| return menu instanceof CraftingStationContainerMenu; |
There was a problem hiding this comment.
Doesn't menu have a getType() method we can use instead of doing an instanceof check? Feels more appropriate to do so, and it would be faster.
There was a problem hiding this comment.
Turns out, crafting tweaks crashes if you use getType in this context on certain screens, guess not every menu supports that function (blame dumb mojang design). So guess the old code is required.
There was a problem hiding this comment.
In which scenarios did it crash?
There was a problem hiding this comment.
Opening the inventory, might have been creative inventory specific
KnightMiner
added
Mod interaction
|
Tested and it works fine, though apparently my earlier suggestion is wrong due to how crafting tweaks works so will need to be reverted to what you had before. After that this should be ready to merge. |
#5004
quick demo
untitled.mp4