Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprited reinforcements #5226

Open
wants to merge 2 commits into
base: 1.19.2
Choose a base branch
from
Open

Resprited reinforcements #5226

wants to merge 2 commits into from

Conversation

Zen9890
Copy link

@Zen9890 Zen9890 commented May 14, 2024

This PR adds resprited versions of new reinforcements, because people in discord noted that specifically iron and gold variants dont look good

Zen9890 added 2 commits May 14, 2024 10:22
Adds resprited pattern that is consistent with resprited reinforcements
@KnightMiner KnightMiner added Textures Pull requests adding in new textures 1.19 Issue affects 1.19 labels Jun 1, 2024
@RCXcrafter
Copy link
Contributor

I'm not sure about the edit for the normal pattern. I don't think it's really needed to make sense, the darker outline could just come from material being cast onto the pattern.
The retextured reinforcements look good though, the border helps to make the icon stand out.

@KnightMiner
Copy link
Member

If the edit to the normal pattern is the base for the new reinforcements, it could always just be saved in the reinforcements folder as the base texture (sorta like how the blank cast is used) then leaving the original pattern unchanged.

@KnightMiner KnightMiner added the Needs Update Issues or PR needs additional action to be taken by the reporter label Sep 16, 2024
@KnightMiner
Copy link
Member

If the edit to the normal pattern is the base for the new reinforcements, it could always just be saved in the reinforcements folder as the base texture (sorta like how the blank cast is used) then leaving the original pattern unchanged.

Please revert the pattern to the original texture, per this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 Issue affects 1.19 Needs Update Issues or PR needs additional action to be taken by the reporter Textures Pull requests adding in new textures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants