-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add SlicerSOFA Extension #2059
Conversation
Could we use SlicerSOFA instead of Slicer-SOFA in both the github repository name and json file? |
Agreed. I will let @RafaelPalomar rename the GitHub project |
This does not build on Windows due to boost. (adding |
@lassoan SOFA does not need to build/install Boost; it uses header-only components. In Slicer/SlicerSOFA#28 we made changes in the build system, so boost is not built nor installed. I have not tried yet on Windows, but this should solve these problems. |
@RafaelPalomar confirmed that the extensions build and packaging now works well on Windows with Slicer/SlicerSOFA#28. If you merge that PR then we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, thanks a lot @RafaelPalomar
New extension
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettings
and in repository settings uncheckWiki
,Projects
, andDiscussions
(if they are currently not used)About
in the top-right corner of the repository main page and uncheckReleases
andPackages
(if they are currently not used)