New comment transition #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of logic here. The idea is to use the default activity transition when starting the comments screen. Previously, we could not do this because the CommentsActivity had a bunch of weird styling (due to SwipeBack). When SwipeBack is active, nothing is changed this way.
First of all, the default theme for CommentsActivity is now AppTheme as this is seemingly required to get the animation to play. Then ThemeUtils may change the theme. For API < 30, we keep SwipeBack as the default theme and don't true to change anything.
For API >= 30, we need to set translucency of the activity to true to enable SwipeBack peeking so this is done. We only do this is SwipeBack is active though because this messes up the animation otherwise. Somewhat surprisingly, on API >= 34, translucency to true is fine, I guess because things have been reworked to help with Predictive Back .