Add option to redirect home page to archive #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonAlling
added a commit
to SimonAlling/userscripter
that referenced
this pull request
Jul 17, 2024
I ran into a confusing problem in SimonAlling/better-sweclockers#264. Consider an operation with this implementation: ```typescript export default (e: { foo: HTMLElement, bar: HTMLElement, baz: HTMLElement, }) => { for (const element of Object.values(e)) { console.log(element); } }; ``` One would expect that all three elements would be logged, but this operation actually does nothing at all. The reason is that the properties of `e` aren't enumerable, so `Object.values(e)` is an empty array. While it's easy to come up with pathological examples of operations that will be broken by this change, it should be backward compatible for all practical intents and purposes. 💡 `git show --color-words=.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users don't like the home page because it doesn't show content in chronological order: articles from several days ago are sometimes bumped, etc. The general consensus, and explicit recommendation from SweClockers themselves, is to use the archive page instead for those who prefer chronological order.
This PR adds an option to redirect the home page to the archive and modify the internal links to the home page to point to the archive instead, as suggested by evil penguin @ SweClockers. (One might argue that the links need not be modified, since the user will be redirected anyway, but that would be slower, use more data and possibly make the home page appear more popular than it actually is.)