Patch preferences shortcut #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe it was broken by the Dark Mode update. 👉 https://www.sweclockers.com/artikel/37572-antligen-halebop-fixar-morkt-tema-pa-sweclockers Regarding icons, SweClockers use `xlink:href` values like this one: /gfx/iconmap.svg?v=20230629#icon_quote I assume that the purpose of `?v=20230629` is cache invalidation. We could probably extract it from one of the default notification icons and use it for the preferences shortcut as well, but it doesn't feel worth it. If it ever breaks due to caching, then we can reconsider. 💡 `git show --color-words='pw-notifications|.'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it was broken by the Dark Mode update.
👉 https://www.sweclockers.com/artikel/37572-antligen-halebop-fixar-morkt-tema-pa-sweclockers
The vanilla notification icons use
xlink:hrefvalues like this one:I assume that the purpose of
?v=20230629is cache invalidation. We could probably extract it from one of the vanilla icons and use it for the preferences shortcut as well, but it doesn't feel worth it. If it ever breaks due to caching, then we can reconsider.💡
git show --color-words='pw-notifications|.'