Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make use of glob utils from eslint #384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SimenB
Copy link
Owner

@SimenB SimenB commented Oct 12, 2016

Ref #381

Need to add test for this, pushing to show progress

/cc @HermitH @wojciechczerniak

@SimenB SimenB self-assigned this Oct 12, 2016
@SimenB
Copy link
Owner Author

SimenB commented Oct 12, 2016

@wojciechczerniak @rossPatton A problem with this is that the eslint extraction is node 4+. Would have to update the code to work with node 0.10.
Alternatively land this just on v2, but that would mean it'd be some time before it's available to consumers. On the other hand, this bug as probably existed for a long time without anyone noticing...

Thoughts?

EDIT: Even making the syntax valid causes it to fail tests because of something deep in shelljs

@sigorilla
Copy link

@SimenB Hi!

I set up some git hooks for my project and I don't want to run stylint for all files, only for changed files. So it would be nice to fix this bug, but also save the node 0.10+ :)

@michalsindelar
Copy link

@sigorilla You can run stylint only on staged files via a bit ugly command e.g.
for f in $(./node_modules/.bin/staged-files); do ./node_modules/.bin/stylint --reporter stylint-stylish $f; done

@SimenB
Copy link
Owner Author

SimenB commented Feb 25, 2017

@sigorilla This is moving slower than I'd like to, and I apologize for that. This won't be fixed for v1, though. Node <4 is EOL now, so I won't spend any time supporting the old versions, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants