Add test helper methods from Rails add-on #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Dec 17, 2024
andyw8
force-pushed
the
andyw8/add-test-helper-methods-from-rails-addon
branch
from
ad468ac to
03ca706
Compare
andyw8
force-pushed
the
andyw8/add-test-helper-methods-from-rails-addon
branch
from
7084ab2 to
d104051
Compare
andyw8
commented
Dec 17, 2024
KaanOzkan
reviewed
Dec 18, 2024
st0012
added
enhancement
st0012
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are currently in ruby-lsp-rails but we also need them for testing the Tapioca LSP. Once this is released, we can remove them from the other places.
I've verified it here. You can see there are some failures but those are releated to changes in the indexing API which we will need to deal with separately.