Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Show Output Channel command for VSCode extension #2986

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Add Show Output Channel command for VSCode extension #2986

merged 3 commits into from
Dec 20, 2024

Conversation

timkooi-jobber
Copy link
Contributor

Motivation

Closes #2958

Implementation

  • Added a new command to package.json for showOutput
  • Utilized the existing client in the workspace to open up the output channel

Automated Tests

No automated tests - I did not see any instances of automated testing for similar commands (collectRubyLspInfo for example). I'd be happy to add some but I didn't really see a pattern for something as straight forward as this.

Manual Tests

  • Open VS Code -> Run and Debug -> Run Extension
  • Ensure existing Ruby LSP is disabled in new VS Code window
  • Open the command palette and search for Ruby LSP: Show Output Channel
Screen.Recording.2024-12-13.at.11.40.55.AM.mov

@timkooi-jobber timkooi-jobber requested a review from a team as a code owner December 13, 2024 19:54
@timkooi-jobber
Copy link
Contributor Author

I have signed the CLA!

vinistock
vinistock reviewed Dec 16, 2024
View reviewed changes
vscode/package.json Outdated Show resolved Hide resolved
vscode/src/rubyLsp.ts Outdated Show resolved Hide resolved
@st0012 st0012 added enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes labels Dec 16, 2024
@andyw8 andyw8 mentioned this pull request Dec 17, 2024
Merged
andyw8
andyw8 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@andyw8 andyw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@andyw8 andyw8 enabled auto-merge (squash) December 20, 2024 18:11
@andyw8 andyw8 merged commit a990ee3 into Shopify:main Dec 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock left review comments

@andyw8 andyw8 andyw8 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add VS Code command to jump directly to Ruby LSP output channel
4 participants
@timkooi-jobber @andyw8 @vinistock @st0012