Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle instance variable target nodes in document symbol #2981

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: Handle instance variable target nodes in document symbol #2981

merged 2 commits into from
Dec 13, 2024

Conversation

Hungle2911
Copy link
Contributor

@Hungle2911 Hungle2911 commented Dec 13, 2024 •
edited
Loading

Motivation

Resolve #2896
Currently, when using destructuring assignment for instance variables only a single document symbol is created. This change ensures each instance variable gets its own document symbol.

Implementation

I've created new listener method to fetch instance_variable_target_node

Automated Tests

Added new test case test_instance_variable_destructuring_assignment that verifies:

  • Basic destructuring assignment of instance variables
  • Correct symbol creation and naming for each instance variable
  • Proper ordering of symbols

@Hungle2911 Hungle2911 requested a review from a team as a code owner December 13, 2024 01:26
@Hungle2911
Copy link
Contributor Author

I have signed the CLA!

@vinistock vinistock added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Dec 13, 2024
vinistock
vinistock approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@vinistock vinistock merged commit 50353f0 into Shopify:main Dec 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle instance variable target nodes in document symbol
2 participants
@Hungle2911 @vinistock