Pass Ruby interpreter path when replacing process by launcher #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Graphite App
andyw8
approved these changes
Dec 12, 2024
vinistock
deleted the
12-12-pass_ruby_interpreter_path_when_replacing_process_by_launcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the error reported in #2936 (comment).
On Windows, it's not possible to invoke
execwith an executable script because the OS doesn't understand the shebang line that defines the Ruby interpreter. We need to manually invoke the Ruby interpreter to run the file.Implementation
Started adding
Gem.rubyto invoke the Ruby interpreter directly. This works on Linux and MacOS too.