Fix debug platform inclusion for Windows #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
vinistock
force-pushed
the
12-12-fix_debug_platform_inclusion_for_windows
branch
4 times, most recently
from
d729aaf to
f52a779
Compare
andyw8
reviewed
Dec 12, 2024
vinistock
force-pushed
the
12-12-fix_debug_platform_inclusion_for_windows
branch
6 times, most recently
from
3122d59 to
6015989
Compare
vinistock
force-pushed
the
12-12-fix_debug_platform_inclusion_for_windows
branch
from
6015989 to
aed3f7a
Compare
st0012
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #1767 (comment), the
mriplatform indeed excludes Windows. Without the right platform constraints, usingdebugon Windows is not possible.Implementation
I reached out to the RubyGems team and apparently there's no platform constraint for MRI on any operating system.
They suggested using
install_ifas a workaround. This isn't exactly the same as a platform constraint, but it seems to achieve the same from practical standpoint.Automated Tests
Added a test that should guarantee that
debugis available on the platforms we support.