Eagerly activate workspaces for opened files #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
approved these changes
Jul 11, 2024
vinistock
force-pushed
the
vs/eagerly_activate_workspaces_for_opened_files
branch
from
7908f3b to
22cc312
Compare
st0012
reviewed
Jul 12, 2024
| scheme: "file", | ||
| language: "ruby", | ||
| }); | ||
| const documentSelector = SUPPORTED_LANGUAGE_IDS.map((language) => ({ |
There was a problem hiding this comment.
Should this be plural? documentSelectors?
There was a problem hiding this comment.
I matched the type name, which is DocumentSelector and is an array of entries.
st0012
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the issue reported in #1897 (comment)
In a multi-root workspace configuration, if you have a Ruby file opened for a secondary workspace, we don't eagerly activate that workspace, despite the file already being opened. You need to switch to another Ruby file for that workspace to have the language server activate, which is a bit odd.
Implementation
Started eagerly activating the workspace for the currently opened file if it's a Ruby file and if the workspace associated with it is not the same as the first one (to avoid any duplicate activations).