Expand addon error information for when addon activation fails #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
May 23, 2024
lib/ruby_lsp/addon.rb
Outdated
| @errors.filter_map(&:backtrace).join("\n\n") | ||
| def errors_details | ||
| @errors.map do |error| | ||
| T.must(error.class.name) + ": " + error.message + "\n" + Array(error.backtrace).join("\n") |
There was a problem hiding this comment.
I don't believe name can ever be nil in this context.
andyw8
added
enhancement
andyw8
changed the title
andyw8
changed the title
6 tasks
andyw8
commented
May 23, 2024
| @@ -104,7 +104,7 @@ def load_addons | |||
| ), | |||
| ) | |||
|
|
|||
| $stderr.puts(errored_addons.map(&:backtraces).join("\n\n")) | |||
| $stderr.puts(errored_addons.map(&:errors_details).join("\n\n")) | |||
There was a problem hiding this comment.
When testing with a raise on the first line of activate in an addon, I found that the Notification (line 97) isn't displaying. I'm not entirely sure why that is yet. But I think it's worth writing the error details alongside the backtrace in stderr.
andyw8
added
server
vinistock
reviewed
May 27, 2024
Co-authored-by: Vinicius Stock <[email protected]>
vinistock
approved these changes
May 27, 2024
andyw8
added a commit
that referenced
this pull request
May 29, 2024
* Expand addon error information * Update lib/ruby_lsp/addon.rb Co-authored-by: Vinicius Stock <[email protected]> * Lint --------- Co-authored-by: Andy Waite <[email protected]> Co-authored-by: Vinicius Stock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @st0012 in standardrb/standard#630 (comment)