-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed background-image from list of supported CSS properties. #6816
base: main
Are you sure you want to change the base?
Removed background-image from list of supported CSS properties. #6816
Conversation
Docs Build status updates of commit 05cd53a: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Technically, I wonder if a better approach might be to add an asterisk to the property and a note under the list describing the issue with parenthesis in values. (Basically everything but rgba() is blocked) |
I'd be happy to make whatever updates the team thinks best, so just let me know how I can help. |
@VesaJuvonen - any feedback on how we can improve this? |
Sorry for playing devils advocate here but technically many those properties can have a '(' in their values. To make it dependant which CSS property is allowed and which not by these characters is might not be the best approache forward. |
We're not in disagreement. I think it's terrible how restricted the CSS values are. Basically, the values are checked for specific use cases like Since this is a discussion of the docs, my suggestion was to at least note the issue on the docs to avoid surprising users. My real ask would be to adjust the silly regex they're using to allow for more valid values but that is something the Microsoft team would have to do whereas the docs are something the community can help with. |
Category
Related issues
What's in this Pull Request?
Removed
background-image
from the list of CSS properties supported with custom column formatting.This
background-image
CSS property requires the use of the '(' character, which is prohibited from use in the formatting schema and results in an error when used.