Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rapid shannon #227

Merged
merged 3 commits into from
Sep 1, 2024
Merged

Refactor rapid shannon #227

merged 3 commits into from
Sep 1, 2024

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Aug 31, 2024

I hereby agree to the terms of the CLA available at: http://www.shannondata.ai/doc/cla/

Summary

reimpl the rapid.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@ShannonBase ShannonBase self-requested a review August 31, 2024 12:59
@ShannonBase ShannonBase self-assigned this Aug 31, 2024
Copy link
Contributor

@ShannonBase ShannonBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

re-impl the rapid engine with a new architect.
@ShannonBase ShannonBase merged commit b41d965 into Shannon-Data:develop Sep 1, 2024
2 checks passed
@RingsC RingsC deleted the refactor-rapid-shannon branch September 1, 2024 06:55
ShannonBase added a commit that referenced this pull request Sep 11, 2024
* refactor(rapid): refact the impl of rapid.

re-impl the rapid engine with a new architect.

---------

Co-authored-by: shannon data ai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants