Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert parallel query #212

Merged
merged 3 commits into from
Aug 3, 2024
Merged

revert parallel query #212

merged 3 commits into from
Aug 3, 2024

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Aug 2, 2024

I hereby agree to the terms of the CLA available at: http://www.shannondata.ai/doc/cla/

Summary

revert parallel query.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

RingsC
RingsC commented Aug 2, 2024
View reviewed changes
Copy link
Contributor Author

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonBase ShannonBase changed the title Develop revert parallel query Aug 2, 2024
ShannonBase
ShannonBase reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ShannonBase ShannonBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ShannonBase
ShannonBase approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ShannonBase ShannonBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonBase ShannonBase merged commit 48d88a6 into Shannon-Data:develop Aug 3, 2024
ShannonBase added a commit that referenced this pull request Aug 3, 2024
@ShannonBase @RingsC
revert parallel query (#212) (#213)
be24758 
* feat(shannon): Native Vector Embeddings Support

* Revert "merge parallel query processing to main (#197)"

This reverts commit 71ec64f.

---------

Signed-off-by: Shannon Data AI Lab <[email protected]>
Co-authored-by: RingsC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonBase ShannonBase ShannonBase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RingsC @ShannonBase