Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shannon):fixup mtr for federate storage #208

Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix(shannon):fixup mtr for federate storage #208

merged 1 commit into from
Jul 13, 2024

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Jul 13, 2024

I hereby agree to the terms of the CLA available at: http://www.shannondata.ai/doc/cla/

Summary

fix up for federate engine in mtr.federate.xxx.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

ShannonBase
ShannonBase approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@ShannonBase ShannonBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonBase ShannonBase added the feature it will be implemented as a new feature label Jul 13, 2024
@ShannonBase ShannonBase self-assigned this Jul 13, 2024
@ShannonBase ShannonBase merged commit 72e73e1 into Shannon-Data:develop Jul 13, 2024
2 checks passed
@RingsC RingsC deleted the fix-up-federate-engine branch July 14, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonBase ShannonBase ShannonBase approved these changes

Assignees

@ShannonBase ShannonBase

Labels
feature it will be implemented as a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RingsC @ShannonBase