Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shannon): new cond for loaded tables #184

Merged
merged 1 commit into from
May 29, 2024
Merged

feat(shannon): new cond for loaded tables #184

merged 1 commit into from
May 29, 2024

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented May 29, 2024

I hereby agree to the terms of the CLA available at: http://www.shannondata.ai/doc/cla/

Summary

adding a new cond for checking whether the loaded tables should be added or not.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

adding a new cond for checking whether the loaded tables should be added or not.
Copy link
Contributor

@ShannonBase ShannonBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonBase ShannonBase self-assigned this May 29, 2024
@ShannonBase ShannonBase added the feature it will be implemented as a new feature label May 29, 2024
@ShannonBase ShannonBase merged commit 2dd1f36 into Shannon-Data:develop May 29, 2024
2 checks passed
@RingsC RingsC deleted the adding-new-cond-for-loaded-table branch May 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature it will be implemented as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants