-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragonflight - Groupe not hide WoW retail #12
Open
Precurseurs
wants to merge
900
commits into
Shadowed:master
Choose a base branch
from
Nevcairiel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes client crashes caused by creating 50000 blocks
10.2 added a new table-type global `STAGGER_STATES` to replace the old decimal variables like `STAGGER_RED_TRANSITION`. These are now undefined (causing lua errors + stagger bar color doesn't work). This commit updates SUF to get stagger thresholds in the [same way official UI code does](https://github.com/Gethe/wow-ui-source/blob/d4aa41ee5366c48fa8a04b9263afec45415c34d2/Interface/FrameXML/MonkStaggerBar.lua#L35).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Activating Shadowed Unit Frame does not hide the group block, even if it is not checked in the edit mode of WoW retail
In addition, if I want to make changes in edit mode, I have to disable the SUF addons.
Thanks for your help
Précurseurs