Fixed build when used in Github Actions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An epsilon parameter is added to the data definition in the SimConnect_AddToDataDefinition function in lib.rs. This replaces the previously hard-coded value of 0.0, allowing for more flexibility depending on the specific requirements of different use cases.
The `add_data_definition` functions in `src/lib.rs` now accept an optional 'epsilon' parameter as opposed to a mandatory float. This modification enhances versatility by accommodating scenarios where 'epsilon' doesn't require a specific value and defaults to 0.0 if not explicitly given.
The add_data_definition method has been updated to include an optional epsilon parameter. This parameter is used to set a threshold for updates, providing more flexibility for data definition. If no specific value for epsilon is provided, it defaults to 0.0.
The simconnect dependency version in the README file is updated from "0.2.0" to "0.2.1". This reflects the current version the project is using and ensures consistency across all parts of the documentation.
The handling of raw pointers and data transmutation in the unsafe blocks has been refactored for better safety and code clarity. Instead of using transmute_copy, it now uses std::ptr::addr_of and std::ptr::read_unaligned to obtain data values.
Updated `simconnect` package from version `0.2.0` to `0.2.1` in `Cargo.lock` file. Introduced two new example scripts `aircraft_updates_on_change` and `aircraft_updates` to demonstrate usage of the libraries. Also, made a minor change in `lib.rs` on how `epsilon` is handled inside `add_data_definition` function.
Updated how data is defined in aircraft_updates_on_change example. Epsilon is now defined to control the frequency of updates from the game, reducing the amount of data sent to the client. For instance, latitude and longitude values update every degree, whereas altitude updates are now received every 100 feet, as opposed to every foot previously.
Added comments in the aircraft_updates_on_change example to explain how different requests need to have unique request_id values in order to prevent data overwrite. Also included a pointer about the way sim_data_ptr uses the passed define_id for better clarity.
Expanded on the usage of KeyValuePairFloat and the need for unique request_id values in the aircraft_updates_on_change example. Clarified how define_id is used with simconnect data by adding detailed comments, helping prevent potential overwrite of data.
This commit rectifies typographical errors and improves the readability of code comments in both the README file and example files. Detailed instructions regarding the execution of examples with SimConnect.dll have been included. Additionally, the datastruct memory allocation has been adjusted for optimal performance and accuracy.
…rust # Conflicts: # Readme.md
This commit corrects typographical errors in the Readme.md file. It also enhances the instructions on building the code and running the examples to help users understand them easily. Hyphenations are also updated to ensure grammatical correctness.
This commit corrects a typographical error in the inline comment when connecting with SimConnect in main.rs within the aircraft_updates_on_change directory. Instead of "Intialize", the correct spelling "Initialize" is now used.
The 'Debug' trait has been derived for the SimConnector struct in lib.rs. This will facilitate easier debugging by allowing SimConnector instances to be formatted using "{:?}" or "{:#?}" for pretty-print, primarily used during development.
The simconnect dependency in the Cargo.toml file has been upgraded from version 0.3.0 to version 0.3.1. This update may include important bug fixes and improvements vital to the project.
Added a new file `examples/aircraft_inputs/main.rs` that provides an example of handling aircraft inputs such as "GEAR_UP", "GEAR_DOWN", and "PARKING_BRAKES". The example includes the setup of a hashmap for input IDs to events cross-referencing and user console input for event triggering. Moreover, SimConnect's version was updated to 0.3.1.
|
@Sequal32 If you want help to maintain this repo, I'm down to help you out. If interested, you can reach me at info@{myusername}.com (to avoid bots scraping the address). |
Sequal32
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Hey @BitsAndDroids thanks so much for your contribution again, and sorry for the delay! I'm going to be active enough to maintain this repo again, and feel free to keep submitting PRs. I'll hopefully be able to get to them quicker.
I'm just glad to see that you're doing well. I also implemented the changes and changed the version (0.4.0 wasn't semver). |
Sequal32
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of nowhere, Bindgen was having issues parsing the issue: #19
header file caused failures downstream when defining the types.
By changing it to:
All seems to work again.
Updated the Bindgen version and replaced a deprecated callback function
This PR also includes the fix for the example "update on change." It could cause a segfault due to an inappropriate pointer arrhythmia. issue: #16
@Sequal32