Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking Operation of Single Shot Measurement Now Optional #36

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ab-tools
Copy link

Hello,

it is very inconvenient that this library enforces a 5 sec. blocking delay when performing a single shot measurement.

It is understood that you need to wait for 5 sec. till the measurement results are available, but this can be done in the calling application in a non-blocking fashion.

I've therefore added a parameter which allows non-blocking operation of the single shot measurement method with blocking mode being the default - so no behavior change for existent applications.

Best regards
Andreas

@psachs
Copy link
Member

psachs commented Jul 23, 2024

I agree, blocking for 5 seconds is way to long. There should be a non-blocking option as well.
Thanks a lot for your contribution.

@psachs psachs merged commit 229d854 into Sensirion:master Jul 23, 2024
4 checks passed
@ab-tools
Copy link
Author

Thanks, Pascal, appreciating your quick feedback and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants