Fix Always Wiping Multisig Descriptor at Main Menu #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PIN change to tools menu
*Add smartcard interface to settings menu *Improve applet install/uninstall functionality
add satochip functions(initialise, seed and enable 2fa)
*Fixes *Rename generic qr type to string
*Improve error messages
Added MicroSD tools
…ard. Add additional seedkeeper functionality.
… a descriptor loaded.
|
@3rdIteration I appreciate all the work and interest in the project, but this PR won't get merged as is. These 2000+ lines of code need to be broken into smaller PRs. Maybe you accidentally pushed all these commits and only meant to push a smaller subset related changes you're proposing for the multisig descriptor verification flow? |
|
Ah that's a typo, this one was meant to be the tiny PR ;) I'll close this one and fix it up at the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Always Wiping Multisig Descriptor at Main Menu
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.