set do_eval

SeanLee97 · Sep 30, 2024 · 157dacc · 157dacc
1 parent d03a118
commit 157dacc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/angle_emb/angle.py b/angle_emb/angle.py
@@ -1531,6 +1531,7 @@ def fit(self,
             dataset_format=self.detect_dataset_format(train_ds),
             train_dataset=train_ds,
             eval_dataset=valid_ds,
+            do_eval=valid_ds is not None,
             loss_kwargs=loss_kwargs,
             tokenizer=self.tokenizer,
             args=TrainingArguments(

diff --git a/angle_emb/angle_trainer.py b/angle_emb/angle_trainer.py
@@ -36,7 +36,8 @@
 parser.add_argument('--valid_split_name', type=str, default='train',
                     help='Specify huggingface datasets split name for valid set, default `train`')
 parser.add_argument('--valid_name_or_path_for_callback', type=str, default=None,
-                    help='Specify huggingface datasets name or local file path for callback valid set, default None.')
+                    help='Specify huggingface datasets name or local file path for callback valid set. '
+                         'The dataset format should be `DatasetFormats.A`. Default None.')
 parser.add_argument('--valid_subset_name_for_callback', type=str, default=None,
                     help='Specify huggingface datasets subset name for valid set for callback use, default None')
 parser.add_argument('--valid_split_name_for_callback', type=str, default='train',