test_session_record_pipe_io_stdin: remove sshpass #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/tlitest/test_tlog_rec_session.py
Outdated
| run(f'sed -i "/stdin_test/d" ~{user}/.ssh/authorized_keys', shell=True) | ||
| run(f'rm -rf ~/.ssh/id_rsa_{user}*', shell=True) | ||
|
|
||
| def _gen_ssh_key(user): |
There was a problem hiding this comment.
I think it makes more sense to generate the SSH key as part of src/tlitest/tlitest-setup then only for test_session_record_pipe_io_stdin pass the SSH command-line options which will use the SSH key. This keeps setup code in one place and allows the tests themselves to be simpler.
spoore1
force-pushed
the
replace_sshpass
branch
5 times, most recently
from
3b1842d to
ba9ce01
Compare
The github action building the fedora container with podman is hitting an error that looks like: error running container: error from /usr/bin/crun creating container for [...]: sd-bus call: Transport endpoint is not connected This requires a workaround to set XDG_RUNTIME_DIR to empty.
spoore1
force-pushed
the
replace_sshpass
branch
4 times, most recently
from
c008ce3 to
35213f3
Compare
Removing reliance on sshpass by adding code in setup to generate an ssh key and use it in the test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing reliance on sshpass by adding code in test case to generate an ssh key and remove it after testing.